Skip to content

Fulu BlobSidecarsByRange/Root Deprecation Support #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SunnysidedJ
Copy link
Contributor

While implementing Lighthouse to avoid serving Fulu slots with BlobSidecarsByRange RPC, @dapplion and I found a need to clarify the deprecation process in the consensus specs. This PR proposes a clearer deprecation transition: allow blob sidecars for pre-Fulu slots within the availability window to be served until full deprecation (i.e., FULU_FORK_EPOCH + MIN_EPOCHS_FOR_BLOCK_REQUESTS or roughly 18 days after the fork). If the request includes Fulu or post-Fulu slots, clients may return an empty list. To ensure a smooth transition, clients should not penalize peers for requesting blob sidecars from Fulu.

The wording and structure of this deprecation policy are informed by the approach used for BeaconBlocksByRange and BeaconBlocksByRoot deprecations in phase0/p2p-interface.md, for consistency across RPCs.

Related discussions:
• Lighthouse issue: sigp/lighthouse#7122 (comment)
• PR discussion: sigp/lighthouse#7328 (comment)

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple very minor nits. The specifications part is spot on though, thank you!

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again!

Copy link
Member

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers, three options we can consider:

  1. reject requests that include slots in range [fulu_fork_slot..]
  2. reject requests that include only slots in range [fulu_fork_slot..]
  3. do not reject any request (this PR)

@jtraglia jtraglia mentioned this pull request May 5, 2025
7 tasks
@jtraglia jtraglia added the Fulu label May 5, 2025
@jtraglia jtraglia merged commit 7273eea into ethereum:dev May 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants