Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Update wallet.sol at solidity v0.4.21#87

Open
JhChoy wants to merge 2 commits intoethereum:masterfrom
JhChoy:patch-1
Open

Update wallet.sol at solidity v0.4.21#87
JhChoy wants to merge 2 commits intoethereum:masterfrom
JhChoy:patch-1

Conversation

@JhChoy
Copy link

@JhChoy JhChoy commented Mar 19, 2018

Apply:
0.4.10 -> 0.4.21
'var' deprecated
use 'public'
mark 'emit'
sha3(deprecated) -> keccak256

JhChoy and others added 2 commits March 19, 2018 13:24
@JhChoy
Update wallet.sol at solidity v0.4.21
e2167fa 
Apply:
 0.4.10 -> 0.4.21
 'var' deprecated
 use 'public'
 mark 'emit'
 sha3(deprecated) -> keccak256
@JhChoy
fix bug
1effb64
tomvanbraeckel
tomvanbraeckel reviewed Sep 6, 2018
View reviewed changes
Copy link

@tomvanbraeckel tomvanbraeckel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not compile:

modifier onlymanyowners(bytes32 _operation) {
    if(confirmAndCheck(_operation));
        _;
}

=> "ParserError: Expected primary expression."

Also, how does this fix a bug, exactly?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tomvanbraeckel tomvanbraeckel tomvanbraeckel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JhChoy @tomvanbraeckel