Refactor API handlers to use centralized Salesforce field mappings #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
corwintines,
minimalsm and
wackerow
as code owners
corwintines
previously approved these changes
Nov 27, 2025
…ny fallback - Add comprehensive test suite for sf-field-mappings covering field mapping, system field exclusion, null handling, and company fallback logic - Remove redundant company fallback from api.ts since it's now handled centrally in mapFormDataToSalesforce
pettinarip
force-pushed
the
refactor-field-mappings
branch
2 times, most recently
from
1881f80 to
7cabd98
Compare
Set up GitHub Actions to run on pushes and PRs to master branch. Uses pnpm for package management. Salesforce contract tests use credentials from GitHub secrets.
pettinarip
force-pushed
the
refactor-field-mappings
branch
from
7cabd98 to
1111195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors API handlers (rfp, wishlist, direct-grant, office-hours) to use the centralized
mapFormDataToSalesforce()function.Description
mapFormDataToSalesforce()from sf-field-mappings.ts as the single source of truth