Fix build failure when Salesforce credentials unavailable #483
Conversation
- Centralized Salesforce credential management to prevent exposure - Added pre-flight file size validation to prevent DOS attacks - Implemented numeric field sanitization for data integrity - Enhanced error handling with structured JSON responses - Added credential validation with fail-fast pattern - Upgraded critical error logging for monitoring systems Resolves security vulnerabilities and data integrity issues across 6 API endpoints without introducing race conditions or memory leaks.
Fixes build failures when SF credentials are not configured by gracefully returning empty array in getGrantInitiativeItems(). This allows: - CI/CD builds without credentials - Local development builds - Static site generation with fallback: 'blocking' to generate pages at runtime The pages use ISR (Incremental Static Regeneration) with fallback: 'blocking', so pages will be generated on first request when credentials are available.
anuragchvn-blip
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
|
| Name | Link |
|---|---|
| 🔨 Latest commit | be2197b |
|
@pettinarip Would appreciate your review on this fix. This resolves build failures when Salesforce credentials aren't configured, which blocks CI/CD and local development builds. |
|
@anuragchvn-blip Hey, thanks for working on this! really appreciate the effort you put into improving the DX. The PR got a bit stale with merge conflicts, and since we only needed the Salesforce credentials handling part right now, I went ahead and created #493 with a minimal fix for that specific issue. Going to close this one, but thanks again for flagging the problem and taking a stab at it! |
|
Thanks for the update and for taking care of this! Totally understand the approach with the minimal fix. Appreciate the kind words and the quick follow-up — glad the issue is resolved. Happy to help again in the future! @pettinarip |
2 participants
Description
Fixes build failures when Salesforce credentials are not configured by gracefully returning empty array in
getGrantInitiativeItems().Changes
getGrantInitiativeItems()to return empty array when credentials missingfallback: 'blocking'to generate on first request when credentials availableImpact
Testing
Verified
npm run buildsucceeds with: