-
Notifications
You must be signed in to change notification settings - Fork 49
feat: Grant round landing pages, Open Rounds tab, and active round banner #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pettinarip
wants to merge
12
commits into
master
Choose a base branch
from
feat/grant-round-landing-pages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement infrastructure for grant round landing pages that aggregate RFP or Wishlist items tagged with a round identifier. Features include: - MDX content files with frontmatter metadata for round configuration - Dynamic [slug].tsx page with hero, sidebar, and item list - Styled MDX components with Chakra UI for consistent rendering - Automatic heading IDs for sidebar navigation - Site-wide banner for active rounds - Salesforce integration to filter items by tag - ISR revalidation for fresh content Includes example AGR26 (Academic Grants Round 2026) content.
- Refactor GrantsHero for separate mobile/desktop layouts with proper background image positioning and gradient overlays - Add floating nav support for hero pages (academic grants and rounds) - Use Chakra semantic z-index tokens instead of hardcoded values - Fix mobile padding consistency in RoundPage
- Add horizontal margins and negative top margin to RoundPage content to create overlap effect with hero section - Update GrantsHero gradient to fade to white for smooth transition - Increase hero height and adjust title box positioning for better vertical centering
Move active round fetching logic from Layout to Banners component, delete the separate ActiveRoundBanner component, and clean up unused theme colors. The banner now self-manages its data fetching and visibility logic.
Simplify active round banner by hardcoding AGR26 data instead of fetching from API. This removes the need for client-side fetching and the associated useState/useEffect hooks. The API endpoint is no longer needed and has been removed. TODO: Replace with server components when available.
…stings - Add new "Open Rounds" tab to /applicants page navigation - Create /applicants/open-rounds page listing active grant rounds - Filter AGR26-tagged items from regular RFP and Wishlist listings - Add getRoundTags() helper to extract round tags from MDX files - Update getGrantInitiativeItems() to exclude round-tagged items by default
…e dependency Refactor grant initiative selection to support mixed item types in round pages: - Create GrantInitiativeSelection component that accepts a getItemUrl function - Simplify RFPSelection and WishlistSelection to wrap the generic component - Update getGrantInitiativeItemsByTag to filter by tag only, not type - Remove itemType from round frontmatter and open-rounds display
Replace oversized heading with a subtle notice box using brand colors, a clock icon, and smaller text that fits better within the page context.
1aaa173 to
2f29433
Compare
Reorder the applicants tabs so Open Rounds appears after RFPs instead of at the beginning of the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/rounds/[slug])/applicants/open-rounds)Test plan
/rounds/agr26to verify MDX rendering and sidebar/applicants/open-roundsand verify AGR26 items filtered from other listingsPreview: https://deploy-preview-494--ecosystem-support.netlify.app/