remove dead google-spreadsheet integration and SF record type env vars#532
Open
pettinarip wants to merge 1 commit into
Open
remove dead google-spreadsheet integration and SF record type env vars#532pettinarip wants to merge 1 commit into
pettinarip wants to merge 1 commit into
Conversation
…env vars - delete src/utils/addRowToSpreadsheet.ts (no callers) - drop google-spreadsheet and @types/google-spreadsheet deps - remove GOOGLE_APPLICATION_CREDENTIALS and GOOGLE_*_SPREADSHEET_ID/SHEET_NAME envs - remove SF_RECORD_TYPE_* envs (record type ids are hardcoded in src/lib/sf-field-mappings.ts and src/lib/sf/index.ts) - update salesforce-mapping skill to point at hardcoded record type ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/utils/addRowToSpreadsheet.ts— the only caller ofgoogle-spreadsheetandGOOGLE_APPLICATION_CREDENTIALS; not imported anywhere.google-spreadsheetand@types/google-spreadsheetfrom dependencies (21 transitive packages removed).SF_RECORD_TYPE_*env vars from.env.local.example— none are referenced insrc/. Record type IDs are hardcoded insrc/lib/sf-field-mappings.ts(per-formHARDWIRED_FIELDS.RecordTypeId) andsrc/lib/sf/index.ts(WISHLIST_RECORD_TYPE_ID,RFP_RECORD_TYPE_ID).GOOGLE_*_SPREADSHEET_ID/GOOGLE_*_SHEET_NAMEenv vars from.env.local.example.salesforce-mappingskill to point at the hardcoded record type IDs instead of the dead env vars.Test plan
npm run type-checkpasses