feat: ETH_UTILS_NOVALIDATE env var for optimized prod use cases #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I was profiling my production app and noticed that quite a lot of time is spent inside the helper functions for
validate_conversion_arguments. While that decorator is very useful for development, it would be beneficial to optionally bypass it for production use cases where the developer is confident they coded their interactions with eth_utils correctly.For this, I have this 2-liner PR that will check if the ETH_UTILS_NOVALIDATE env var is set to any value. If it is,
validate_conversion_argumentswill be bypasses and the original input function will be returned.Related to Issue # N/A
Closes # N/A
How was it fixed?
Todo:
Cute Animal Picture