WIP Chromatic workflow update #13607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg canceled.
|
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
| # 👇 Adds Chromatic as a step in the workflow | ||
| uses: chromaui/action@v1 | ||
| - name: Build Storybook | ||
| run: npm run build-storybook |
There was a problem hiding this comment.
Do you think the build-storybook:chromatic script currently in the package.json is no longer needed?
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
Status: Stale
github-actions
bot
added
the
abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the chromatic workflow using the
tj-actions/changed-filesaction approach (https://www.chromatic.com/docs/github-actions/#skip-chromatic-in-a-monorepo-when-no-ui-files-have-changed).Approach to be tested and see if we can required this as a status check in the branch protection rules and, at the same time, without requiring this check in all the PRs.