Refactor i18n Message Loading #15282
Merged
+230
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
pettinarip
force-pushed
the
fix-load-messages-2
branch
from
38f6e34 to
515d434
Compare
pettinarip
force-pushed
the
fix-load-messages-2
branch
from
515d434 to
f3c2588
Compare
pettinarip
commented
Apr 15, 2025
| @@ -17,7 +17,7 @@ export default getRequestConfig(async ({ requestLocale }) => { | |||
|
|
|||
| const allLocaleMessages = await loadMessages(locale) | |||
| const allDefaultMessages = await loadMessages(routing.defaultLocale) | |||
| const messages = merge(allDefaultMessages, allLocaleMessages) | |||
| const messages = merge({}, allDefaultMessages, allLocaleMessages) | |||
There was a problem hiding this comment.
Avoids mutating the original object. This was creating weird behaviors with how the locales were loaded.
wackerow
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Looks great, and working well on my end. Thanks @pettinarip! pulling in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
loadMessageswith Next.js'sgetMessagesfromnext-intl/serversetRequestLocalecalls for proper locale context"src/intl/**/*"in netlify.toml file because its not detected now that we are usinggetMessagesinstead ofloadMessages