Fix raw translation keys leaking after useTranslations migration

[pettinarip]

Description

Fixes the Chromatic page-visual-test regression on tutorial pages caught on the v11.15.0 deploy PR (#18820): the skill tag rendered the raw key PAGE-DEVELOPERS-TUTORIALS:PAGE-TUTORIAL-BEGINNER instead of "Beginner", breaking the tag row layout.

Root cause: 780bc22 migrated TutorialMetadata to next-intl's namespace-bound useTranslations, but getSkillTranslationId still returned the legacy namespace:key form, which next-intl cannot resolve.

Changes:

• getSkillTranslationId returns the bare key (page-tutorial-*); the tutorials listing uses its namespace-bound t() instead of the legacy <Translation> id form.
• Same bug class in app/[locale]/quizzes/page-jsonld.tsx: t("common:quizzes-title") on a page-quizzes-bound translator leaked the raw key into the JSON-LD WebPage/breadcrumb names. Now uses a common-bound translator.

A codebase-wide sweep found no other namespace:key strings passed to bound next-intl translators.

Verified locally: type-check + lint pass; tutorial page renders the BEGINNER tag with baseline layout, tutorials listing pills correct, quizzes JSON-LD emits "Quiz Hub".

Targets staging to unblock the v11.15.0 release.

[netlify]

✅ Deploy Preview for ethereumorg ready!

Name	Link
🔨 Latest commit	fc99718
🔍 Latest deploy log	https://app.netlify.com/projects/ethereumorg/deploys/6a590cd4d1aa5200087349b2
😎 Deploy Preview	https://deploy-preview-18823.ethereum.it
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	7 paths audited Performance: 60 (🟢 up 4 from production) Accessibility: 95 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 60 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

🔎 First-pass review — ✅ Looks mergeable

Tight, correct fix for the raw-key leak introduced when TutorialMetadata moved to next-intl namespace-bound useTranslations. getSkillTranslationId now returns the bare key and both call sites (TutorialMetadata.tsx, tutorials.tsx) resolve it through their page-developers-tutorials-bound t() — verified the page-tutorial-{beginner,intermediate,advanced} keys exist in that namespace. The quizzes JSON-LD fix is the same bug class: quizzes-title lives in common, so the new common-bound tCommon() is the right binding. Targeting staging to unblock v11.15.0 is appropriate.

Analysis

Lane: code (3 files: TutorialMetadata.tsx, tutorials.tsx, quizzes/page-jsonld.tsx).

Checked:

• Both getSkillTranslationId callers bind t to page-developers-tutorials; returned keys resolve there → "Beginner"/"Intermediate"/"Advanced". ✅
• quizzes-title present in common.json ("Quiz Hub"); tCommon binding correct. ✅
• No remaining namespace:key usages of the helper (grep confirms only the two call sites). ✅
• Translation import still used elsewhere in both touched files — no unused import. ✅
• TranslationKey = string, so the bare-key return type is satisfied.

CI still running on a fresh PR — nothing to flag there. No blocking or non-blocking issues found.

Generated by PR Reviewer (team) for #18823 · 73.2 AIC · ⌖ 10.3 AIC · ⊞ 5.2K · ◷

[github-actions]

Page	Performance	Accessibility	Best practices	SEO	PWA

Lighthouse scores are calculated based on the latest audit results