Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Casper FFG test net compatibility #1015

Open
wants to merge 74 commits into
base: develop
Choose a base branch
from
Open

Casper FFG test net compatibility #1015

wants to merge 74 commits into from

Conversation

zilm13
Copy link
Collaborator

@zilm13 zilm13 commented Feb 22, 2018

NO MERGE
A lot of refactoring to go.
Only for develop diff.

@zilm13 zilm13 requested a review from mkalinin February 22, 2018 16:15
@zilm13
Copy link
Collaborator Author

zilm13 commented Feb 22, 2018

TODO: add Test for CasperTransactionExecutor with vote to check that gas is not used and rewards are correct

zilm13 added 16 commits February 23, 2018 00:41
@zilm13
TransactionExecutor split to standard implementation and Casper version
ebe5fb0
@zilm13
Fixing Spring circular references
d736638
@zilm13
Fixing miner rejects casper votes
3f1b724
@zilm13
Fixed Ethereum Harmony build dependency failing
726f4f7
@zilm13
Init Casper with passed params instead of hexcode
e2e3fd6
@zilm13
Added Casper Epoch test + minor fixes
71dde8d
@zilm13
Quick fix casper votes are dropped
a50d280
@zilm13
Fixed sync not done after miner start
6b0f381
@zilm13
Added simple casper validator test, fixed voting in casper validator …
4369d4f 
…service
@zilm13
Added logging of my validator stats
a556ecc
@zilm13
Added validator logout test
492468e
@zilm13
Fixed processed txs removal
4818249
@zilm13
Fixed basis test was started, but shouldn't
5287b22
@zilm13
Refactored null sender txs signing
b47e24c
@zilm13
Started to detaching Casper in separate package: Config moved
068152a
@zilm13
Moved Blockchain and validators out of consensus strategy
3a88e8b
@zilm13 zilm13 changed the title Casper FFG test net implementation Casper FFG test net compatibility Mar 2, 2018
@zilm13
Copy link
Collaborator Author

zilm13 commented Mar 14, 2018 •
edited
Loading

TODO:

  1. should epoch switch costs gas?
  2. for failed casper vote, we are substituting fee from tx.sender, but the sender is fffffffffff.. ?
  1. no
  2. if a casper vote's sender is ffffffffff, and the casper vote fails, that's an invalid transaction, and if that tx is part of the block then the block is invalid. pyethapp is currently incorrectly implemented

@zilm13
Copy link
Collaborator Author

zilm13 commented Mar 14, 2018 •
edited
Loading

  1. postpone as we will need to restart testnet for it, implemented in 8ec6864
  2. postpone for the same reason, block 1480 already has failed deposit, implemented in
    c72cb9d

zilm13 and others added 24 commits March 14, 2018 17:04
@zilm13
Make casper epoch switch free
8ec6864
@zilm13
Revert "Make casper epoch switch free"
845c0bf 
This reverts commit 8ec6864.
@zilm13
Don't subtract fee from null sender on succesful casper vote. Instead…
c72cb9d 
…, block should be INVALID
@zilm13
Fixed makeInitTxs
2117fdc
@zilm13
Logging of casper address added
3a3e536
@zilm13
Trying to fix github tests with delay after failed request
13fda70
@zilm13
Revert "Don't subtract fee from null sender on succesful casper vote.…
0cc765d 
… Instead, block should be INVALID"

This reverts commit c72cb9d.
@zilm13
Removed TransactionExecutorFactory
3f39e57
@zilm13
Storing finalized checkpoints in separate source
bc829f6
@zilm13
Fixed Casper test (finalizedBlocks storage was not set)
d7703cb
@zilm13
Merge branch 'develop' into research/casper
2517cc0
@zilm13
Revert "Revert "Make casper epoch switch free""
cce4815 
This reverts commit 845c0bf.
@zilm13
Revert "Revert "Don't subtract fee from null sender on succesful casp…
5e13b15 
…er vote. Instead, block should be INVALID""

This reverts commit 0cc765d.
@zilm13
Testing that no gas was used for casper service txs and bad casper vo…
9840b71 
…tes are not included in blocks
@zilm13
Merge branch 'develop' into research/casper
d0cea52
@zilm13
Merge branch 'develop' into research/casper
ad92db0
@zilm13
Merge branch 'develop' into research/casper
33e6721
@mkalinin
CasperFacade: use apache.commons Pair instead of javafx.util Pair
feb3f91
@zilm13
Added transaction executor note for casper service txs
84a3254
@zilm13
Bump Casper contract to commit #251a1a349fddd90b40febf9781ffc92e8c6a4a0e
6760e96
@zilm13
Temporary EIP-86 partial implementation
179888a
@zilm13
Fixing Circle CI for Casper branch
e835c4a
@zilm13
Refactored tx validation
316c43d
@zilm13
Testing chainId compatibility
29614b4
@zilm13
Copy link
Collaborator Author

zilm13 commented Apr 12, 2018

  • add optional slashing condition watcher

@mkalinin
Copy link
Contributor

Closing it

@mkalinin mkalinin closed this Jun 14, 2018
@zilm13 zilm13 reopened this Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkalinin mkalinin mkalinin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zilm13 @coveralls @mkalinin