Fix to expmod precompile gas calculation #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1176 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 171 171
Lines 19676 19687 +11
=======================================
+ Hits 18671 18682 +11
Misses 1005 1005
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
force-pushed
the
precompiles/fix_expmod_gas
branch
2 times, most recently
from
96674ed to
e5a4ddb
Compare
chfast
force-pushed
the
precompiles/fix_expmod_gas
branch
from
e165b28 to
7b03fc1
Compare
chfast
force-pushed
the
precompiles/fix_expmod_gas
branch
2 times, most recently
from
9bf56bc to
4dd801d
Compare
chfast
force-pushed
the
precompiles/fix_expmod_gas
branch
2 times, most recently
from
992144c to
45b766f
Compare
rodiazet
approved these changes
Apr 15, 2025
test/state/precompiles.cpp
Outdated
| const auto base_len = be::unsafe::load<uint256>(&input_header[0]); | ||
| const auto exp_len = be::unsafe::load<uint256>(&input_header[32]); | ||
| const auto mod_len = be::unsafe::load<uint256>(&input_header[64]); | ||
| const auto adjusted_len = [input](size_t offset, uint32_t len) { |
There was a problem hiding this comment.
It's valid only for calculation of adjusted exp len. Should we call it adjusted_exp_len?
There was a problem hiding this comment.
Added prefix calc_ for helper function to distinguish it from values. And renamed this to calc_adjusted_exp_len().
Fix and refactor gas cost calculation for the expmod precompile. The issue was that some computations could overflow and the result was incorrect. This was found by a fuzzer so some test vectors are included.
chfast
force-pushed
the
precompiles/fix_expmod_gas
branch
from
45b766f to
f322609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and refactor gas cost calculation for the expmod precompile.
The issue was that some computations could overflow and the result
was incorrect.
This was found by a fuzzer so some test vectors are included.