eof: Remove support for EOF Creation Transaction #1190
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
- Coverage 94.84% 94.78% -0.07%
==========================================
Files 171 171
Lines 19501 19256 -245
==========================================
- Hits 18496 18251 -245
Misses 1005 1005
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gumb0
force-pushed
the
eof/drop-eof-create-tx
branch
from
04dc99e to
fa6226c
Compare
gumb0
force-pushed
the
eof/drop-eof-create-tx
branch
from
5ee1029 to
3f282f4
Compare
gumb0
force-pushed
the
eof/drop-eof-create-tx
branch
from
3f282f4 to
c0014e1
Compare
pdobacz
approved these changes
Apr 10, 2025
| @@ -754,74 +822,6 @@ bool is_eof_container(bytes_view container) noexcept | |||
| return container.starts_with(EOF_MAGIC); | |||
| } | |||
|
|
|||
| std::variant<EOF1Header, EOFValidationError> validate_header( | |||
There was a problem hiding this comment.
If I'm not mistaken, this is just moved to a private namespace, no changes?
gumb0
force-pushed
the
eof/drop-eof-create-tx
branch
from
c0014e1 to
46fac88
Compare
pdobacz
force-pushed
the
eof/drop-eof-create-tx
branch
from
46fac88 to
41a600d
Compare
This is simplification, it is more natural to check it together with the check for truncated body. This check was earlier moved into higher-level function to allow for stray bytes in EOF Creation Transactions.
No need to call from EOF Creation Transaction processing anymore.
pdobacz
force-pushed
the
eof/drop-eof-create-tx
branch
from
41a600d to
d639188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.