Conversation
|
Moved EIP-7805 spec under the experimental folder. Thank you for your review and providing the reference! @ensi321 |
|
I think |
e518c7b to
572c54c
Compare
|
Will |
|
|
||
| #### Response | ||
|
|
||
| * result: `inclusionList`: `Array of DATA` - Array of transaction objects, each object is a byte list (`DATA`) representing `TransactionType || TransactionPayload` or `LegacyTransaction` as defined in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718). |
There was a problem hiding this comment.
We can introduce a response object like it is done in the forkchoiceUpdated case. Should we extend inclusion list with some meta information in the future, it will be smoother with an object in response
There was a problem hiding this comment.
We had object for that purpose but removed it as it makes the caller's job easier. I want to ask @terencechain's opinion on this. Relevant discussion here.
|
There are some potential changes in queue and I'd like to share them here. They're queued because we want to make big changes altogether as we already have +5 clients implemented. Being SFI'd could be a good signal to make such changes.
|
|
I’d suggest we use a different name than |
|
Reflected the changes in the queue. Here is a change log:
Note: the fork check using timestamp is not specified. It should be specified once this merges into some canonical fork. |
|
|
||
| #### Response | ||
|
|
||
| * result: [`PayloadStatusV1`](./paris.md#payloadstatusv1), values of the `status` field are modified in the following way: |
There was a problem hiding this comment.
Why don't we define PayloadStatusV2?
There was a problem hiding this comment.
We add one enum value without changing its structure and it seems the spec doesn't add another version in such cases. It's not a strong opinion though. Should we define PayloadStatusV2?
There was a problem hiding this comment.
Currently, the spec doesn’t require to bump a version in this case, see here for all cases where the version change is required — we can definitely extend this list if we find it reasonable. But I am personally leaning towards not adding a new version in this particular case as the change doesn’t affect the layout of the PayloadStatus
|
I've revamped and rebased this PR to Bogotá fork. I'd like to get feedback on
|
This PR adds the engine APIs FOCIL spec on Bogota fork. It mainly adds or modifies three new methods.
i)
engine_newPayloadV6engine_newPayloadV6takes an inclusion list (IL) as an additional parameter and verifies if the payload satisfies the IL constraints. (For the IL constraints, please refer toExecution Layersection in EIP-7805.)ii)
engine_getInclusionListV1EL must provide an IL (a list of transactions) when
engine_getInclusionListV1is called. FOCIL as in EIP-7805 does not dictate IL building algorithm and expects the diversity would foster censorship resistance.iii)
engine_forkchoiceUpdatedV5A proposer should listen to all ILs submitted by IL committee members and apply the aggregated IL to its payload before proposing a block. We add the IL field to
payloadAttributesand callforkchoiceUpdatedinitially with a null IL field at the start of a slot, then call it again with the actual IL once it’s ready.