update tests for new maxGasUsed field#765
Closed
Rhovian wants to merge 3 commits intoethereum:mainfrom
Closed
Conversation
Contributor
|
You have CI failures, looks like |
Contributor
Author
|
@MysticRyuujin thanks, fixed |
Contributor
|
I believe these tests were generated with a version of geth that had a bug in eth_simulate. We've fixed them since in ethereum/go-ethereum#33952. I noticed while trying to also fill these tests in #763. If you notice some gas limit fields changed which should be unrelated to maxGasUsed. |
Contributor
Author
|
@s1na will re-run from that new commit, thanks |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
As per #746, the new
maxUsedGasfield requires test regeneration, this PR addresses that.go-ethereum pr merged here: ethereum/go-ethereum#32789
Methodology
cc @bomanaps @MysticRyuujin