Skip to content

update tests for new maxGasUsed field#765

Closed
Rhovian wants to merge 3 commits intoethereum:mainfrom
Rhovian:chore/tests-bump-maxUsedGas
Closed

update tests for new maxGasUsed field#765
Rhovian wants to merge 3 commits intoethereum:mainfrom
Rhovian:chore/tests-bump-maxUsedGas

Conversation

@Rhovian
Copy link
Copy Markdown
Contributor

@Rhovian Rhovian commented Mar 4, 2026

Context

As per #746, the new maxUsedGas field requires test regeneration, this PR addresses that.

go-ethereum pr merged here: ethereum/go-ethereum#32789

Methodology

  • Bumped go-ethereum in tools/go.mod to latest master (which includes go-ethereum#32789)
  • Ran make fill in tools/ to regenerate all test fixtures
  • Fixed two tests whose balances were no longer sufficient due to increased gas costs from the new gas accounting, then re-ran make fill to confirm zero failures

cc @bomanaps @MysticRyuujin

@MysticRyuujin
Copy link
Copy Markdown
Contributor

You have CI failures, looks like go.mod and go.sum need cleanup

@Rhovian
Copy link
Copy Markdown
Contributor Author

Rhovian commented Mar 5, 2026

@MysticRyuujin thanks, fixed

@s1na
Copy link
Copy Markdown
Contributor

s1na commented Mar 6, 2026

I believe these tests were generated with a version of geth that had a bug in eth_simulate. We've fixed them since in ethereum/go-ethereum#33952. I noticed while trying to also fill these tests in #763.

If you notice some gas limit fields changed which should be unrelated to maxGasUsed.

@Rhovian
Copy link
Copy Markdown
Contributor Author

Rhovian commented Mar 6, 2026

@s1na will re-run from that new commit, thanks

@Rhovian
Copy link
Copy Markdown
Contributor Author

Rhovian commented Mar 7, 2026

@s1na confirmed that bug -- see you have a PR for these changes as well, closing this one out in favor of #763

@Rhovian Rhovian closed this Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants