eth: add spec and rpctestgen tests for eth_getTransactionBySenderAndNonce#771
Draft
MysticRyuujin wants to merge 1 commit intoethereum:mainfrom
Draft
eth: add spec and rpctestgen tests for eth_getTransactionBySenderAndNonce#771MysticRyuujin wants to merge 1 commit intoethereum:mainfrom
MysticRyuujin wants to merge 1 commit intoethereum:mainfrom
Conversation
…once Adds the OpenRPC method definition and test generators for eth_getTransactionBySenderAndNonce, fixing ethereum#494. The method searches the pending txpool before consulting historical chain data. Pending transactions are returned with null block-contextual fields. go-ethereum implementation: ethereum/go-ethereum#33854
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #494.
Adds the OpenRPC method definition and rpctestgen test generators for
eth_getTransactionBySenderAndNonce.Spec
nullblockHash,blockNumber,blockTimestamp, andtransactionIndexTests
get-legacy-tx— lookup a mined legacy transaction by sender+nonceget-dynamic-fee-tx— lookup a mined EIP-1559 transaction by sender+nonceget-tx-in-pool— submit a transaction then look it up from the pending poolget-notfound— returnsnullfor an address with no transactionsTest fixtures will be generated once geth implements the method (go-ethereum: ethereum/go-ethereum#33854).