Update testing_buildBlockV1 fixtures#783
Open
newmanifold wants to merge 2 commits intoethereum:mainfrom
Open
Conversation
…only - Regenerate fixtures against geth with slotNumber omitempty and real blockValue - Mark build-block-from-mempool as SpecOnly since mempool tx selection is not deterministic
newmanifold
force-pushed
the
fix/testing-buildblock-fixtures
branch
from
0030bd8 to
5dd2c39
Compare
newmanifold
changed the title
MariusVanDerWijden
pushed a commit
to ethereum/go-ethereum
that referenced
this pull request
Apr 13, 2026
Two fixes for `testing_buildBlockV1`: 1. Add `omitempty` to `SlotNumber` in `ExecutableData` so it is omitted for pre-Amsterdam payloads. The spec defines the response as `ExecutionPayloadV3` which does not include `slotNumber`. 2. Pass `res.fees` instead of `new(big.Int)` in `BuildTestingPayload` so `blockValue` reflects actual priority fees instead of always being zero. Corresponding fixture update: ethereum/execution-apis#783
Contributor
|
LGTM |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues with the testing_buildBlockV1 test fixtures:
Remove
slotNumber: nullfrom responses. The spec defines the response asExecutionPayloadV3which does not includeslotNumber(that's V4/Amsterdam). The test chain is Prague-only.Update
blockValueto reflect actual priority fees instead of hardcoded0x0.Mark
build-block-from-mempoolasSpecOnlysince mempool tx selection varies across clients (ordering, min tip thresholds).Fixtures regenerated with
rpctestgenagainst ethereum/go-ethereum#34704 (merged).go.modpin updated.