Skip to content

feat(tests): port ethereum/tests swap opcode tests #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bomanaps
Copy link

πŸ—’οΈ Description

Port test for swap opcode ported from ethereum/tests.

πŸ”— Related Issues

Closes #1012

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for implementing this.

There's a couple of comments I think should be addressed before merging, but overall it's a very good PR!

uv.lock Outdated
@@ -590,7 +590,7 @@ requires-dist = [
{ name = "pytest-metadata", specifier = ">=3,<4" },
{ name = "pytest-xdist", specifier = ">=3.3.1,<4" },
{ name = "pyyaml", specifier = ">=6.0.2,<7" },
{ name = "questionary", git = "https://github.com/tmbo/questionary?rev=ff22aeae1cd9c1c734f14329934e349bec7873bc#ff22aeae1cd9c1c734f14329934e349bec7873bc" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this file out of the PR for the time being πŸ‘

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @bomanaps is using uv>=0.8.22 - this is due to:

Copy link
Member

@danceratopz danceratopz Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bomanaps no action required regarding your uv version at the moment, I think everyone else needs to upgrade their uv.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why uv.lock is deleted?

@danceratopz danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature labels Feb 5, 2025
@danceratopz danceratopz changed the title Port test for swap opcode feat(tests): port ethereum/tests swap opcode tests Feb 5, 2025
@danceratopz danceratopz added the port Related to porting ethereum/tests to EEST label Feb 7, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments.

@bomanaps bomanaps requested a review from marioevz March 27, 2025 11:07
@bomanaps bomanaps requested a review from danceratopz April 10, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port Related to porting ethereum/tests to EEST scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(tests): SwapFiller.yml
4 participants