-
Notifications
You must be signed in to change notification settings - Fork 122
feat(tests): port ethereum/tests swap opcode tests #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for implementing this.
There's a couple of comments I think should be addressed before merging, but overall it's a very good PR!
uv.lock
Outdated
@@ -590,7 +590,7 @@ requires-dist = [ | |||
{ name = "pytest-metadata", specifier = ">=3,<4" }, | |||
{ name = "pytest-xdist", specifier = ">=3.3.1,<4" }, | |||
{ name = "pyyaml", specifier = ">=6.0.2,<7" }, | |||
{ name = "questionary", git = "https://github.com/tmbo/questionary?rev=ff22aeae1cd9c1c734f14329934e349bec7873bc#ff22aeae1cd9c1c734f14329934e349bec7873bc" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave this file out of the PR for the time being π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @bomanaps is using uv>=0.8.22
- this is due to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bomanaps no action required regarding your uv version at the moment, I think everyone else needs to upgrade their uv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why uv.lock is deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments.
ποΈ Description
Port test for
swap
opcode ported fromethereum/tests
.π Related Issues
Closes #1012
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.