-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(getting_started,fill): add solc instructions for arm64 users with fill issues #1217
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding this, nice that we have ARM users covered too!
Few suggestions below.
…4 users with fill issues
4f51b32
to
f227c01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the suggestions, @felix314159.
Following Spencer's offline comment about macOS ARM64, it seems that we need to be a little more precise about the platforms.
@spencer-tb do these make sense to you?
uv sync --all-extras | ||
uv run solc-select use 0.8.24 --always-install | ||
``` | ||
=== "x86-64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=== "x86-64" | |
=== "All x86-64 platforms and ARM64 macOS" |
Co-authored-by: danceratopz <[email protected]>
Co-authored-by: danceratopz <[email protected]>
Co-authored-by: danceratopz <[email protected]>
This looks good to me and happy with this as is! Although maybe its clearer to keep the initial installation commands as they were before, pointing people to troubleshooting directly afterwards. Not that architecture is hard to check, but for the basic new user it might be! |
🗒️ Description
When using ARM64 you can't use the solc x86-64 that you end up with when following the old instructions in the docs. Updated the docs with a guide to install solc on ARM and a description of the fill issue that would have resulted if an ARM user would not have followed these instructions.
🔗 Related Issues
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.