Skip to content

feat(clis,consume): add nethermind support to consume direct#1250

Merged
danceratopz merged 9 commits intomainfrom
add-nethtest
Mar 13, 2025
Merged

feat(clis,consume): add nethermind support to consume direct#1250
danceratopz merged 9 commits intomainfrom
add-nethtest

Conversation

@danceratopz
Copy link
Copy Markdown
Member

@danceratopz danceratopz commented Feb 24, 2025

🗒️ Description

Adds support for consuming state test, blockchain test and eof test fixtures with Nethermind's direct client test interface nethtest.

To run with eof test fixtures, the feature/evm/eof Nethermind branch is required:

dotnet build ./src/Nethermind/EthereumTests.slnx -c release
ln -s (pwd)/src/Nethermind/artifacts/bin/Nethermind.Test.Runner/release/nethtest ~/bin/nethtest

Then, for example:

set -x DOTNET_ROOT /usr/share/dotnet
uv run consume direct --input=eip7692@latest --bin=~/bin/nethtest -n 8  # --sim.limit=".*-eof_test.*"

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.

@danceratopz danceratopz added type:feat type: Feature scope:consume Scope: Consume command suite labels Feb 24, 2025
Copy link
Copy Markdown
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments! Thanks for adding this! My vote is for reth next 🥲

@danceratopz danceratopz changed the title feat(consume): add nethermind support to consume direct feat(clis,consume): add nethermind support to consume direct Mar 13, 2025
@danceratopz danceratopz requested a review from spencer-tb March 13, 2025 14:47
Copy link
Copy Markdown
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the changelog conflict. I think we need the new section post release!

@danceratopz danceratopz merged commit b614b9d into main Mar 13, 2025
21 checks passed
@danceratopz danceratopz deleted the add-nethtest branch March 13, 2025 15:10
@felix314159
Copy link
Copy Markdown
Collaborator

felix314159 commented May 8, 2025

How to build nethtest:

sudo apt install -y dotnet-sdk-9.0

git clone --recursive https://github.com/NethermindEth/nethermind
-> double-check to ensure you use --recursive

cd nethermind && git checkout 1.31.10
-> 1.31.10 happens to be the latest release currently

dotnet build ./src/Nethermind/EthereumTests.sln -c release
-> This builds the nethtest binary
-> nethtest binary is in ./src/Nethermind/artifacts/bin/Nethermind.Test.Runner/release/nethtest

dotnet build ./src/Nethermind/Nethermind.sln -c release
-> This builds the nethermind binary (not needed by eest), which is in ./src/Nethermind/artifacts/bin/Nethermind.Runner/release/nethermind

You can run tests but it will take long time and might have errors:
dotnet test ./src/Nethermind/EthereumTests.sln -c release
-> e.g. Output:
Test summary: total: 5067, failed: 2, succeeded: 5061, skipped: 1, duration: 51.0s
Build failed with 4 error(s) in 2190.4s

dotnet test ./src/Nethermind/Nethermind.sln -c release
-> e.g. Output:
Test summary: total: 9443, failed: 18, succeeded: 9231, skipped: 156, duration: 366.6s
Build failed with 18 error(s) and 69 warning(s) in 369.0s

I think I got errors in the past because I didn't clone recursively and then it complained about a few missing files (but still managed to build nethermind but not nethtest). But these instructions work for me

felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
…eum#1250)

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:consume Scope: Consume command suite type:feat type: Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants