Skip to content

fix(tests): EOF - Align EOFCREATE args with EXT*CALL #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

fix(tests): EOF - Align EOFCREATE args with EXT*CALL #1274

merged 1 commit into from
Apr 8, 2025

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Feb 27, 2025 •
edited by chfast
Loading

🗒️ Description

Update with ipsilon/eof#156, planned for EOF Osaka-devnet-1. EOFCREATE stack args order to match that of EXT*CALL.

Filling requires evmone with an update which will be flagged below 👇

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz self-assigned this Feb 27, 2025
@pdobacz pdobacz mentioned this pull request Feb 27, 2025
Merged
@pdobacz pdobacz mentioned this pull request Mar 6, 2025
Closed
5 tasks
@pdobacz pdobacz mentioned this pull request Mar 21, 2025
Merged
@pdobacz pdobacz force-pushed the eofcreate-stack-order branch from 8221aca to c4053db Compare April 7, 2025 17:46
@pdobacz pdobacz marked this pull request as ready for review April 8, 2025 06:33
@pdobacz pdobacz requested review from marioevz and gumb0 April 8, 2025 06:33
@pdobacz pdobacz force-pushed the eofcreate-stack-order branch from c4053db to 93eff2c Compare April 8, 2025 08:39
@chfast chfast added the scope:tests Scope: Changes EL client test cases in `./tests` label Apr 8, 2025
@pdobacz pdobacz merged commit e0eeecb into ethereum:main Apr 8, 2025
11 checks passed
@pdobacz pdobacz deleted the eofcreate-stack-order branch April 8, 2025 12:59
pacrob pushed a commit to pacrob/execution-spec-tests that referenced this pull request May 5, 2025
@pdobacz @pacrob
fix(tests): EOF - Align EOFCREATE args with EXT*CALL (ethereum#1274)
2b6ed9a
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@pdobacz @felix314159
fix(tests): EOF - Align EOFCREATE args with EXT*CALL (ethereum#1274)
f3f68ea
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jul 1, 2025
@pdobacz @Carsons-Eels
fix(tests): EOF - Align EOFCREATE args with EXT*CALL (ethereum#1274)
8d1885a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@marioevz marioevz Awaiting requested review from marioevz

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees

@pdobacz pdobacz

Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdobacz @chfast @marioevz