Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): EOF - Align EOFCREATE args with EXT*CALL #1274

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Feb 27, 2025

🗒️ Description

Update with ipsilon/eof#156, planned for EOF Osaka-devnet-1. EOFCREATE stack args order to match that of EXT*CALL.

Filling requires evmone with an update which will be flagged below 👇

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@@ -282,7 +282,7 @@ def test_calldata(state_test: StateTestFiller, pre: Alloc):
sections=[
Section.Code(
code=Op.MSTORE(0, Op.PUSH32(calldata))
+ Op.SSTORE(slot_create_address, Op.EOFCREATE[0](0, 0, 0, calldata_size))
+ Op.SSTORE(slot_create_address, Op.EOFCREATE[0](input_size=calldata_size))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes could go in even if the opcode stack order doesn't change in the end 😀

Is there any other opcode getting a similar change? We could prepare a PR with only keyword-argument changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other opcode that I know of (well, TXCREATE, but there aren't eest test yet). However, I have spidey sense that we'll be asked to have EXTCALL re-aligned with CALL again. So maybe you're right to split, I'll work on that on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants