feat(test-convert) : Fillerconvert WIP parse .json test vectors #1294
Conversation
file.txt
Outdated
There was a problem hiding this comment.
Unintentionally added file perhaps?
| import tempfile | ||
|
|
||
| from pydantic.functional_validators import BeforeValidator | ||
| from typing_extensions import Annotated |
There was a problem hiding this comment.
| from typing_extensions import Annotated | |
| from typing import Annotated |
| return "0x" + b.hex() | ||
|
|
||
|
|
||
| AddressInFiller = Annotated[str, BeforeValidator(parse_address)] |
There was a problem hiding this comment.
Seems to me that Address should work here, but is there any reason why it doesn't?
|
|
||
|
|
||
| AddressInFiller = Annotated[str, BeforeValidator(parse_address)] | ||
| ValueInFiller = Annotated[str, BeforeValidator(parse_hex_number)] |
There was a problem hiding this comment.
Similar to previous comment, would HexNumber work here?
|
|
||
| AddressInFiller = Annotated[str, BeforeValidator(parse_address)] | ||
| ValueInFiller = Annotated[str, BeforeValidator(parse_hex_number)] | ||
| CodeInFiller = Annotated[str, BeforeValidator(parse_code)] |
There was a problem hiding this comment.
I agree that the BeforeValidator is definitely needed here, but I think it would be better to have:
| CodeInFiller = Annotated[str, BeforeValidator(parse_code)] | |
| CodeInFiller = Annotated[Bytes, BeforeValidator(parse_code)] |
Just to not have to work with strings.
There was a problem hiding this comment.
It won't serialize if its Bytes
| for key, value in account.storage.items(): | ||
| storage[key] = value | ||
|
|
||
| # TODO looks like pyspec post state verification will not work for default values? |
There was a problem hiding this comment.
We can use model_fields_set of the account to see if a value was explicitly set.
For example, if "balance" in account.model_fields_set, it means the value was explicitly set to zero instead the value being zero because if fell back to the default.
| AddressInFiller = Annotated[str, BeforeValidator(parse_address)] | ||
| ValueInFiller = Annotated[str, BeforeValidator(parse_hex_number)] | ||
| CodeInFiller = Annotated[str, BeforeValidator(parse_code)] | ||
| Hash32InFiller = Annotated[str, BeforeValidator(parse_hash32)] |
There was a problem hiding this comment.
It seems like Hash should work here without issues.
There was a problem hiding this comment.
I thought it was better to separate pydantic for the testFiller scope. Otherwise, schemas get mixed here and there.
So this part of the code would not depend on existing pyspec pydantic schemas. we won't need to maintain it and once the tests are converted it can be archived. and if any logic will be required during pydantic implementation of this schemas I won't need to interfere into existing pyspecs.
Fillerconvert changes by Mario
support different transaction types parse labels in code
🗒️ Description
WIP prototype of .json/yml test fillers
I added pydantic models (WIP) of state test fillers.
and a function that will build pyspec transition test out of it.
lost of logic to port and reimplement in python. here is just an example of how it will look like.
General Idea:
-take .json test filler -> get list of individual test vectors (id, env, pre, tx, post) -> run state_test() normally
the complexity raises because original state test filler hash vector of [tx] and [post] that need to be parsed back to single test again. which I think is in the end better idea. due to a complexity of having many test vectors in one file, we will have 1 vector 1 file. even though env,pre is copied
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.