-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EXTDELEGATECALL blocking vs 7702 #1309
base: main
Are you sure you want to change the base?
Conversation
e630579
to
477da7f
Compare
``
|
) | ||
|
||
calling_storage = { | ||
slot_code_worked: value_code_worked, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also good. there is one more way.
storage = Storage()
code = Op.SSTORE(storage.store_next(<expected condition>, "debug hint"), Op.EXTDELEGATECALL(..))
post = { expected_account : Account( storage = storage) }
Like this it will print debug hint in case the value returned will be not equal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I know this one, I just want to be consistent with the file. Also sometimes current layout is more readable. Let me know if you insist on such a refactor to go in this PR.
🗒️ Description
I worked on amending the spec for EXTDELEGATECALL restrictions and realized I'm not sure parts of it were tested. They were, but not in an explicitly intentional manner and also not through the lens of 7702. So there it is.
I'm not entirely sure I'm handling the migration trackers correctly - there's no such thing as
src/EIPTestsFiller/StateTests/stEOF/stEIP3540/EOF1_CallsFiller.yml
inethereum/tests
?🔗 Related Issues
NA
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.