new(tests): EOF - EXTDELEGATECALL blocking vs 7702#1309
Merged
marioevz merged 5 commits intoethereum:mainfrom Apr 1, 2025
Merged
new(tests): EOF - EXTDELEGATECALL blocking vs 7702#1309marioevz merged 5 commits intoethereum:mainfrom
marioevz merged 5 commits intoethereum:mainfrom
Conversation
pdobacz
force-pushed
the
extdelegatecall-7702
branch
from
e630579 to
477da7f
Compare
|
`` |
winsvega
reviewed
Mar 17, 2025
winsvega
reviewed
Mar 17, 2025
pdobacz
force-pushed
the
extdelegatecall-7702
branch
from
3f3ce49 to
6903d3e
Compare
marioevz
reviewed
Mar 31, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Looks good! Just added a couple of suggestions to add more coverage.
pdobacz
force-pushed
the
extdelegatecall-7702
branch
from
4a2c32e to
7a31d4e
Compare
Co-authored-by: Mario Vega <marioevz@gmail.com>
pdobacz
force-pushed
the
extdelegatecall-7702
branch
from
7a31d4e to
9c59dd2
Compare
marioevz
approved these changes
Apr 1, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM thanks for the changes!
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
* new(tests): EOF - EXTDELEGATECALL blocking vs 7702 * new(tests): EOF - EXT*CALL backfill test cases * Apply code review suggestions * Refactor target_address to fixture * Apply code review Co-authored-by: Mario Vega <marioevz@gmail.com> --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
* new(tests): EOF - EXTDELEGATECALL blocking vs 7702 * new(tests): EOF - EXT*CALL backfill test cases * Apply code review suggestions * Refactor target_address to fixture * Apply code review Co-authored-by: Mario Vega <marioevz@gmail.com> --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
I worked on amending the spec for EXTDELEGATECALL restrictions and realized I'm not sure parts of it were tested. They were, but not in an explicitly intentional manner and also not through the lens of 7702. So there it is.
I'm not entirely sure I'm handling the migration trackers correctly - there's no such thing as
src/EIPTestsFiller/StateTests/stEOF/stEIP3540/EOF1_CallsFiller.ymlinethereum/tests?🔗 Related Issues
NA
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.