Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EXTDELEGATECALL blocking vs 7702 #1309

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Mar 13, 2025

🗒️ Description

I worked on amending the spec for EXTDELEGATECALL restrictions and realized I'm not sure parts of it were tested. They were, but not in an explicitly intentional manner and also not through the lens of 7702. So there it is.

I'm not entirely sure I'm handling the migration trackers correctly - there's no such thing as src/EIPTestsFiller/StateTests/stEOF/stEIP3540/EOF1_CallsFiller.yml in ethereum/tests?

🔗 Related Issues

NA

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz added the scope:tests Scope: Changes EL client test cases in `./tests` label Mar 13, 2025
@pdobacz pdobacz self-assigned this Mar 13, 2025
@pdobacz pdobacz force-pushed the extdelegatecall-7702 branch from e630579 to 477da7f Compare March 13, 2025 17:14
@pdobacz pdobacz requested review from gumb0 and marioevz March 13, 2025 17:14
@winsvega
Copy link
Contributor

``
I'm not entirely sure I'm handling the migration trackers correctly - there's no such thing as src/EIPTestsFiller/StateTests/stEOF/stEIP3540/EOF1_CallsFiller.yml in ethereum/tests?

those are mostly migrated tests. we don't refer to test repo for EOF tests anymore

)

calling_storage = {
slot_code_worked: value_code_worked,
Copy link
Contributor

@winsvega winsvega Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also good. there is one more way.

storage = Storage()

code = Op.SSTORE(storage.store_next(<expected condition>, "debug hint"),   Op.EXTDELEGATECALL(..))

post = {  expected_account : Account( storage = storage) } 

Like this it will print debug hint in case the value returned will be not equal

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I know this one, I just want to be consistent with the file. Also sometimes current layout is more readable. Let me know if you insist on such a refactor to go in this PR.

@pdobacz pdobacz requested a review from winsvega March 18, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants