EIP-7748 tests #1312
Draft
EIP-7748 tests #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Mar 13, 2025
Comment on lines
-992
to
+998
| Address(0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFE): { | ||
| "nonce": 1, | ||
| "code": ( | ||
| "0x60203611603157600143035f35116029575f35612000014311602957612000" | ||
| "5f3506545f5260205ff35b5f5f5260205ff35b5f5ffd00" | ||
| ), | ||
| } | ||
| # Address(0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFE): { | ||
| # "nonce": 1, | ||
| # "code": ( | ||
| # "0x60203611603157600143035f35116029575f35612000014311602957612000" | ||
| # "5f3506545f5260205ff35b5f5f5260205ff35b5f5ffd00" | ||
| # ), | ||
| # } |
There was a problem hiding this comment.
@spencer-tb, this is a quick hack to disable the automatic inclusion of the EIP-2935 system contract. Ideally, I want this feature to avoid having this extra address in the genesis state since we want full predictability on which accounts exist for the tree conversion tests.
I think once we talked about an extra flag to do this more cleanly.
| @@ -57,7 +57,7 @@ def test_balance(blockchain_test: BlockchainTestFiller, fork: Fork, target, warm | |||
| ], | |||
There was a problem hiding this comment.
From this point forward, the changes are mostly the new tests so nothing framework related.
tests/verkle/eip7748/accounts.py
Outdated
| REFERENCE_SPEC_GIT_PATH = "EIPS/eip-7748.md" | ||
| REFERENCE_SPEC_VERSION = "TODO" | ||
|
|
||
| stride = 7 |
There was a problem hiding this comment.
Until the testing framework supports the stride as a filling option, I'm hardcoding it. This value allows me to create most of the test cases I want anyway.
See corresponding comment in go-ethereum
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
…artial conversion Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress for EIP-7748 (Tree conversion) tests.
uv run fill --from Shanghai --until EIP6800Transition -v -m blockchain_test -n 8 --evm-bin=<evm path> --evm-dump-dir=out ./tests/verkle/eip7748Use this branch for filling.