Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF validation CALLF stack overflow #1329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Mar 19, 2025

πŸ—’οΈ Description

πŸ”— Related Issues

βœ… Checklist

@hugo-dc hugo-dc requested a review from chfast March 19, 2025 09:36
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, thanks!

However, I'd put all tests in tests/osaka/eip7692_eof_v1/eip4750_functions/test_code_validation.py. There are already stack overflow tests for CALLF there.
Test function names are good though, no need to change them.

Also stack overflow tests for JUMPF are in tests/osaka/eip7692_eof_v1/eip6206_jumpf/test_jumpf_validation.py. I.e. it seems we are grouping validation tests by opcode rather than by the validation kind (stack height in this case).

@hugo-dc hugo-dc force-pushed the callf_stack_overflow branch 2 times, most recently from 78e1d54 to 208df96 Compare March 20, 2025 06:57
@hugo-dc hugo-dc force-pushed the callf_stack_overflow branch from 208df96 to 6143ef1 Compare March 20, 2025 07:09
@hugo-dc
Copy link
Member Author

hugo-dc commented Mar 20, 2025

I have moved the tests into the file containing the existing callf tests as you suggested.

@hugo-dc hugo-dc force-pushed the callf_stack_overflow branch 3 times, most recently from ee06b74 to 6143ef1 Compare March 23, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants