Skip to content

new(tests): Add EOF validation tests for stack underflow #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

new(tests): Add EOF validation tests for stack underflow #1331

merged 1 commit into from
Apr 7, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Mar 19, 2025 •
edited
Loading

🗒️ Description

Port ethereum/tests EOF validation tests for stack underflow.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened. delete converted EOF stack underflow tests tests#1476
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast requested review from hugo-dc, gumb0 and pdobacz March 19, 2025 12:05
@chfast chfast added the scope:tests Scope: Changes EL client test cases in `./tests` label Mar 19, 2025
@chfast chfast force-pushed the eof/stack_underflow branch from f49311a to c99f0b2 Compare March 19, 2025 12:06
marioevz
marioevz reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, thanks!

pdobacz
pdobacz reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second Mario's comments + one suggestion

@chfast chfast mentioned this pull request Apr 1, 2025
Merged
8 tasks
@chfast chfast force-pushed the eof/stack_underflow branch 2 times, most recently from 3a6d54d to d0c99bc Compare April 7, 2025 14:36
@chfast chfast force-pushed the eof/stack_underflow branch from d0c99bc to cafebd2 Compare April 7, 2025 15:01
marioevz
marioevz approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 08a60c9 into ethereum:main Apr 7, 2025
11 checks passed
@marioevz marioevz deleted the eof/stack_underflow branch April 7, 2025 16:24
pacrob pushed a commit to pacrob/execution-spec-tests that referenced this pull request May 5, 2025
@chfast @pacrob
new(tests): Add EOF validation tests for stack underflow (ethereum#1331)
26f5b48
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@chfast @felix314159
new(tests): Add EOF validation tests for stack underflow (ethereum#1331)
0da56ea
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jul 1, 2025
@chfast @Carsons-Eels
new(tests): Add EOF validation tests for stack underflow (ethereum#1331)
22295a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdobacz pdobacz pdobacz left review comments

@marioevz marioevz marioevz approved these changes

@hugo-dc hugo-dc Awaiting requested review from hugo-dc

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @pdobacz @marioevz