new(tests): EOF validation RETF stack overflow

[hugo-dc]

🗒️ Description

🔗 Related Issues

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
• Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened. Remove converted EOF RETF stack overflow tests tests#1478
• Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[winsvega]

@marioevz
the expected_bytecode was a temporary feature, this will require huge efforts of maintenance as eof format changes. consider disabling expected_bytecode verification in most of the EOF tests.

[marioevz]

Looks great! Just a few comments, and I echo Dimitry's comment that expected_bytecode could be removed, specially when we already have PRs like #1339 where adding more tests that use this field would result in more rework.

[marioevz]

I think both branches underflow in this case, it would be nice to see:

• Case where it only underflows in the jump branch (Edit: covered in case below)
• Case where it only underflows in the no-jump branch (no-jump pops from the stack for example).

[marioevz]

Suggested change

	code=Op.PUSH0 + Op.PUSH1[0] + Op.RJUMPI[2] + Op.PUSH0 * 2 + Op.RETF,
	code=Op.PUSH0 + Op.PUSH1[0] + Op.RJUMPI[1] + Op.PUSH0 + Op.RETF,

We should also include the case where it overflows by one stack item only.

[marioevz]

Also similar comment to one in the previous test function, we should add a variant where it overflows in the jumping branch, for example:

Op.PUSH0 + Op.PUSH1[0] * 2 + Op.RJUMPI[1] + Op.POP + Op.RETF