feat(tests): extra BLS12-381 coverage #1350
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
force-pushed
the
tests-bls12-additional-coverage
branch
from
ebdfb04 to
1965e8d
Compare
36 tasks
11 tasks
spencer-tb
force-pushed
the
tests-bls12-additional-coverage
branch
from
1965e8d to
ad15a45
Compare
spencer-tb
changed the title
spencer-tb
commented
Apr 3, 2025
There was a problem hiding this comment.
Seems this was my mistake, and a duplicate, it exists in vectors/.
spencer-tb
force-pushed
the
tests-bls12-additional-coverage
branch
from
ad15a45 to
923d08b
Compare
spencer-tb
added
scope:tests
|
looks good. need to fix linter |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Primarily adds additional coverage to g1/g2 add/mul/msm and pairing functions.
Includes a BLS point generator class that is used in for some of the test vectors. This may be used for future fuzzing.
Future Todo:
spec.py, to add test cases for these points, they take a long time to generate hence why they can't be created on the fly via fill.🔗 Related Issues
Previous vector addition is included here: #1289 (to explain why we are deleting
tests/prague/msm_G1_bls.json.✅ Checklist