Skip to content

feat(tests): Remove redundant Blake2 fixtures and callcode tests #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Apr 7, 2025

πŸ—’οΈ Description

Fixed a couple issues in the recent blake2 merge.

  • Fixture for generating contract opcode was removed
  • Removed blake2 callcode tests that are covered by those in test_blake2b

πŸ”— Related Issues

#1244, #1395

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@reedsa reedsa requested a review from marioevz April 7, 2025 18:17
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a single comment!

@reedsa reedsa force-pushed the blake2-fix-bad-merge branch from 671e837 to bfa23f2 Compare April 7, 2025 20:19
@reedsa reedsa force-pushed the blake2-fix-bad-merge branch from bfa23f2 to 3561f22 Compare April 7, 2025 20:34
@marioevz marioevz merged commit 36c5f13 into ethereum:main Apr 8, 2025
12 checks passed
pacrob pushed a commit to pacrob/execution-spec-tests that referenced this pull request May 5, 2025
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants