chore(forks): osaka tweak and fix blob schedule logic #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
added
scope:forks
marioevz
reviewed
Apr 14, 2025
| @@ -975,7 +975,7 @@ def blob_schedule(cls, block_number: int = 0, timestamp: int = 0) -> BlobSchedul | |||
| max_blobs_per_block=cls.max_blobs_per_block(block_number, timestamp), | |||
| base_fee_update_fraction=cls.blob_base_fee_update_fraction(block_number, timestamp), | |||
| ) | |||
| if last_blob_schedule is None or last_blob_schedule != current_blob_schedule: | |||
| if parent_fork.name() != cls.name() or last_blob_schedule != current_blob_schedule: | |||
There was a problem hiding this comment.
If the goal is to add an entry to every fork, even if there's no blob changes between previous fork and current one, then we can remove a lot of the logic, but we also should add a test to https://github.com/ethereum/execution-spec-tests/blob/main/src/ethereum_test_forks/tests/test_forks.py, which should verify that the entry is added to the fork even when it has no blob_schedule changes:
class NewTestFork(Prague):
...
assert NewTestFork.blob_schedule() == {"Cancun": ..., "Prague": ..., "NewTestFork": ...}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Updates the logic in forks, such that we always include the blob schedule within the fixtures for any new fork.
Additionally removes
CancunEIP7692.🔗 Related Issues
N/A.
✅ Checklist
All: Added an entry to CHANGELOG.md.