Skip to content

chore(forks): osaka tweak and fix blob schedule logic #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Apr 11, 2025

πŸ—’οΈ Description

Updates the logic in forks, such that we always include the blob schedule within the fixtures for any new fork.

Additionally removes CancunEIP7692.

πŸ”— Related Issues

N/A.

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added scope:forks Scope: Changes ethereum_test_forks package type:chore Type: Chore fork:osaka Osaka hardfork labels Apr 11, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, thanks!

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Simplified the logic and added a new unit test in the last commit.

@marioevz marioevz merged commit 3719e92 into main Apr 21, 2025
21 checks passed
@marioevz marioevz deleted the spencer-tb/osaka-blob-schedule branch April 21, 2025 18:05
pacrob pushed a commit to pacrob/execution-spec-tests that referenced this pull request May 5, 2025
* chore(forks): osaka tweak and fix blob schedule logic.

* refactor and add unit test

---------

Co-authored-by: Mario Vega <[email protected]>
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
* chore(forks): osaka tweak and fix blob schedule logic.

* refactor and add unit test

---------

Co-authored-by: Mario Vega <[email protected]>
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jul 1, 2025
* chore(forks): osaka tweak and fix blob schedule logic.

* refactor and add unit test

---------

Co-authored-by: Mario Vega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork scope:forks Scope: Changes ethereum_test_forks package type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants