-
Notifications
You must be signed in to change notification settings - Fork 153
feat(static tests) : do not compile test fillers source code while loading the models #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
65e4eee
to
8a295d3
Compare
restored this logic |
needs to be called after filling of the fixtures has finished. or in case of exception or keyboard interrupt and we are exiting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few comments, let me know what you think about the docker alternative.
Each legacy test filler has only 1 test per file if it's a !state test! So no need to create directory Add11/add11.json it can be plain add11.json
0123bd6
to
fb9dc13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified and all legacy tests are filling locally, I think we can go ahead and merge this plus #1442.
I marked the last checkbox in the description because we are now using locally built |
…while loading the models (ethereum#1439) * do not compile test fillers source code while loading the models * support docker lllc image * export filled static state tests into test suite folder. Each legacy test filler has only 1 test per file if it's a !state test! So no need to create directory Add11/add11.json it can be plain add11.json * Apply suggestions from code review * fix(specs): Prefer local `lllc` binary * feat(filler): Allow arbitrary markers for static tests * feat(specs): Read pytest markers from static yml/json files * fix(filler): Propagate parametrize marks to generated test * fix(specs/static_state): Parametrization to add `exception_test` marker * fix(plugins/filler): Use sorted intersection fork set * fix: tox * Update src/ethereum_test_specs/static_state/common/common.py --------- Co-authored-by: Mario Vega <[email protected]>
…while loading the models (ethereum#1439) * do not compile test fillers source code while loading the models * support docker lllc image * export filled static state tests into test suite folder. Each legacy test filler has only 1 test per file if it's a !state test! So no need to create directory Add11/add11.json it can be plain add11.json * Apply suggestions from code review * fix(specs): Prefer local `lllc` binary * feat(filler): Allow arbitrary markers for static tests * feat(specs): Read pytest markers from static yml/json files * fix(filler): Propagate parametrize marks to generated test * fix(specs/static_state): Parametrization to add `exception_test` marker * fix(plugins/filler): Use sorted intersection fork set * fix: tox * Update src/ethereum_test_specs/static_state/common/common.py --------- Co-authored-by: Mario Vega <[email protected]>
…while loading the models (ethereum#1439) * do not compile test fillers source code while loading the models * support docker lllc image * export filled static state tests into test suite folder. Each legacy test filler has only 1 test per file if it's a !state test! So no need to create directory Add11/add11.json it can be plain add11.json * Apply suggestions from code review * fix(specs): Prefer local `lllc` binary * feat(filler): Allow arbitrary markers for static tests * feat(specs): Read pytest markers from static yml/json files * fix(filler): Propagate parametrize marks to generated test * fix(specs/static_state): Parametrization to add `exception_test` marker * fix(plugins/filler): Use sorted intersection fork set * fix: tox * Update src/ethereum_test_specs/static_state/common/common.py --------- Co-authored-by: Mario Vega <[email protected]>
@marioevz please don't merge there are bullet points to complete:
- [x] Make sure exceptions are working correctly after mapper refactoring (too many things to fix) #1440
the test generation is supported with lllc from docker hub.
https://hub.docker.com/r/winsvega/lllc
it works fast using docker exec. all we need is to pull a docker image in our CI