Skip to content

fix(tests,fw): Remove EIP-7698 EOF creation txs #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 17, 2025

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Apr 15, 2025

πŸ—’οΈ Description

Draft removal of EIP-7698. Some interesting test cases in EIP-7698 were recreated in other categories

πŸ”— Related Issues

NA

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz added the scope:tests Scope: Changes EL client test cases in `./tests` label Apr 15, 2025
@pdobacz pdobacz self-assigned this Apr 15, 2025
@pdobacz pdobacz marked this pull request as ready for review April 16, 2025 16:34
@pdobacz
Copy link
Collaborator Author

pdobacz commented Apr 16, 2025

@marioevz Not 100% sure the solutions around the state/bc tests generators are elegant, but I think this is ok to review now. Fills successfully with evmone on branch eof/drop-eof-create-tx

@marioevz marioevz added the fork:prague Prague hardfork label Apr 16, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, some comments on the PR before merging.

@marioevz marioevz merged commit d2b5148 into ethereum:main Apr 17, 2025
11 checks passed
@marioevz marioevz deleted the remove-7698 branch April 17, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:prague Prague hardfork scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants