chore(eels): update to use forks/prague
#1454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
force-pushed
the
update-eels-forks-prague
branch
from
8aaf45b to
bf942c1
Compare
|
Note: We should "Rebase and merge" instead of the usual "Squash and merge" in order to preserve both commits and be able to |
3 tasks
danceratopz
reviewed
Apr 16, 2025
There was a problem hiding this comment.
Thanks for this, especially the test!
LGTM, holding off approval until ethereum/execution-specs#1191 is merged.
danceratopz
changed the title
forks/prague.forks/prague
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Updates EELS to fill tests using
forks/praguebranch.Currently, some of the tests in main fail to fill because PR ethereum/execution-specs#1191 is required, and once merged, all tests should fill properly.
This PR also includes a workaround for this issue: ethereum/execution-specs#1194
The workaround should be removed once the issue is resolved.
🔗 Related Issues
None
✅ Checklist