Skip to content

new(tests): EOF validation stack_range maximally broad #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

new(tests): EOF validation stack_range maximally broad #1457

merged 1 commit into from
Apr 17, 2025

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Apr 16, 2025 •
edited by chfast
Loading

🗒️ Description

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened. Remove stack range maximally broad tests#1484
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@hugo-dc hugo-dc force-pushed the stack_range_maximally_broad branch from daa8026 to deabe6b Compare April 16, 2025 01:02
@chfast chfast added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature fork:osaka Osaka hardfork labels Apr 16, 2025
@chfast chfast requested review from chfast and pdobacz April 16, 2025 07:56
chfast
chfast approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some editorial changes should improve it.

@hugo-dc hugo-dc force-pushed the stack_range_maximally_broad branch from deabe6b to 7082600 Compare April 16, 2025 23:36
@hugo-dc hugo-dc force-pushed the stack_range_maximally_broad branch from 7082600 to b66ec5b Compare April 16, 2025 23:54
@chfast chfast merged commit 074dbc0 into ethereum:main Apr 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@pdobacz pdobacz Awaiting requested review from pdobacz

Assignees
No one assigned
Labels
fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugo-dc @chfast