refactor(tests): update JUMPF EOF tests to max_stack_increase #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates EIP-6206 (JUMPF) tests to use `max_stack_increase` instead of `max_stack_height`. In many places the value is correctly auto-computed so for these cases the explicit value is omitted.
chfast
added
scope:tests
pdobacz
approved these changes
Apr 17, 2025
| @@ -391,7 +390,7 @@ def test_jumpf_to_returning_variable_stack_3(eof_test: EOFTestFiller): | |||
| Section.Code( | |||
| code=Op.REVERT(0, 0), | |||
| code_inputs=1, | |||
| max_stack_height=3, | |||
There was a problem hiding this comment.
difference here is != code_inputs, but it looks sensible. Can you confirm this is intended?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This updates EIP-6206 (JUMPF) tests to use
max_stack_increaseinstead ofmax_stack_height.In many places the value is correctly auto-computed so for these cases the explicit value is omitted.
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.