Skip to content

refactor(tests): update function EOF tests to max_stack_increase #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(tests): update function EOF tests to max_stack_increase #1468

wants to merge 1 commit into from

Conversation

chfast
Copy link
Member

@chfast chfast commented Apr 16, 2025 •
edited
Loading

🗒️ Description

This updates EIP-4750 (functions) tests to use max_stack_increase instead of max_stack_height.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast added scope:tests Scope: Changes EL client test cases in `./tests` type:refactor Type: Refactor fork:osaka Osaka hardfork labels Apr 16, 2025
@chfast chfast requested a review from hugo-dc April 16, 2025 17:31
@chfast
refactor(tests): update function EOF tests to max_stack_increase
b32c46d 
This updates EIP-4750 (functions) tests to use `max_stack_increase`
instead of `max_stack_height`.
@chfast chfast force-pushed the eof/max_stack_increase_update_functions branch from f009693 to b32c46d Compare April 16, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugo-dc hugo-dc Awaiting requested review from hugo-dc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:refactor Type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chfast