Skip to content

fix(tests): EIP-7620 - make CREATE/CREATE2 restrictions specific #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): EIP-7620 - make CREATE/CREATE2 restrictions specific #1475

wants to merge 1 commit into from

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Apr 17, 2025 •
edited
Loading

🗒️ Description

I've noticed that the assertions in one of the tests were quite loose, so I made them more specific

🔗 Related Issues

NA

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz requested review from chfast and marioevz April 17, 2025 09:15
@pdobacz pdobacz self-assigned this Apr 17, 2025
@pdobacz pdobacz added the scope:tests Scope: Changes EL client test cases in `./tests` label Apr 17, 2025
@chfast chfast added the fork:osaka Osaka hardfork label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast Awaiting requested review from chfast

@marioevz marioevz Awaiting requested review from marioevz

At least 1 approving review is required to merge this pull request.

Assignees

@pdobacz pdobacz

Labels
fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdobacz @chfast