new(tests): EIP-7873 expand legacy creation tx tests #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdobacz
force-pushed
the
creation-tx-7873
branch
from
7348b7e to
79e6310
Compare
chfast
reviewed
Apr 23, 2025
tests/osaka/eip7692_eof_v1/eip7873_tx_create/test_creation_tx.py
Outdated
Show resolved
Hide resolved
pdobacz
force-pushed
the
creation-tx-7873
branch
from
226e9bb to
af1ba09
Compare
chfast
approved these changes
Apr 23, 2025
… tx, but should fail execution (ethereum#1480)" This reverts commit 13fecee.
pdobacz
force-pushed
the
creation-tx-7873
branch
from
af1ba09 to
f016b89
Compare
pacrob
pushed a commit
to pacrob/execution-spec-tests
that referenced
this pull request
May 5, 2025
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
(requires evmone with this update to fill) EDIT: Merged
Also NOTE that, same as #1475 this PR adds tests and facilities for behavior of "legacy creation txs" (to: nil, EOF container in data), which is likely to change based on recently obtained feedback.
I'd like to merge this as a baby step (and #1475) and then update the behavior in a proper PR
🔗 Related Issues
NA
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.