Skip to content

feat(execute): Mainnet marked tests #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Apr 30, 2025

🗒️ Description

Mark a subset of prague tests as mainnet-sanity tests.

The idea behind this PR is to:

  • Mark at least one test per EIP to run in mainnet after the fork activation in order to sign-off the fork.
  • The selected tests must be extremely simple and use a minimal amount of gas and preferably no Eth value.
  • The tests would be executed using uv run execute remote --fork=Prague -m mainnet ....
  • The tests can be displayed using uv run fill --fork=Prague -m mainnet --collect-only for reference.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@spencer-tb
Copy link
Contributor

Would it be better to add the mainnet marks on a per test case basis?

      pytest.param(
            Spec.G1ADD,
            Spec.G1 + Spec.INF_G1,
            Spec.G1,
            None,
            id="G1ADD",
            marks=[pytest.mark.mainnet]
        ),

@marioevz marioevz force-pushed the mainnet-marked-tests branch from 454978e to c47b047 Compare April 30, 2025 23:54
…cker

This fixes up the previous commit that no longer includes the `spec_version_checker` plugin when executing `fill` or `execute` by removing it from their pytest-*ini files.
@danceratopz
Copy link
Member

@marioevz I removed the EIP spec version checker from fill's and execute's pytest*.ini files to stop these tests causing noise for ethPandaOps whilst using this branch. I am addressing this change properly in another PR.

@danceratopz
Copy link
Member

@marioevz I removed the EIP spec version checker from fill's and execute's pytest*.ini files to stop these tests causing noise for ethPandaOps whilst using this branch. I am addressing this change properly in another PR.

WIP -> #1537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants