chore(cli): update exception mapper for nimbus-el #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
added
type:chore
winsvega
reviewed
May 5, 2025
| TransactionException.TYPE_4_TX_CONTRACT_CREATION: ( | ||
| "set code transaction must not be a create transaction" | ||
| # TODO: these need to be fixed / incorrectly mapped | ||
| TransactionException.INSUFFICIENT_MAX_FEE_PER_GAS: ( |
There was a problem hiding this comment.
if the exception string is different to the exception meaning. we can create another exception code for nimbus, and then in the test add this to the list of possible exceptions
TransactionException.INSUFFICIENT_MAX_FEE_PER_GAS| TransactionException.ZERO_GAS_USED
but only if the exception logic by nimbus is correct
winsvega
reviewed
May 5, 2025
| ), | ||
| TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: ( | ||
| "max fee per blob gas less than block blob gas fee" | ||
| "zero gasUsed but transactions present" |
There was a problem hiding this comment.
there must be a validation for the map that does not allow to have 2 different exception codes with the same exception string/pattern. otherwise we can invent redundant exception codes and forget.
winsvega
reviewed
May 5, 2025
| mapping_regex: ClassVar[Dict[ExceptionBase, str]] = { | ||
| TransactionException.INSUFFICIENT_ACCOUNT_FUNDS: ( | ||
| r"(invalid tx: not enough cash to send)|" | ||
| r"(zero gasUsed but transactions present)" # TODO: Needs fix. |
There was a problem hiding this comment.
why on so many codes it falls to this error string?
perhaps nimbus shall improve their exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Updates the exception mapper for nimbus-el.
WIP - still needs some fixes on the nimbus-el side, as a lot of the exceptions return the same "zero gasUsed but transactions present" string.
🔗 Related Issues
N/A
✅ Checklist