Skip to content

feat(coverage): enable blockchain test converted coverage support #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

feat(coverage): enable blockchain test converted coverage support #1554

merged 1 commit into from
May 7, 2025
+3 −1

Conversation

winsvega
Copy link
Contributor

@winsvega winsvega commented May 6, 2025 •
edited
Loading

🗒️ Description

allow coverage check of .json files from BlockchainTests folders

🔗 Related Issues

#1535

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega changed the title enable blockchain test converted coverage support feat(coverage): enable blockchain test converted coverage support May 6, 2025
@winsvega winsvega self-assigned this May 6, 2025
@winsvega winsvega added scope:ci Scope: Continuous Integration port Related to porting ethereum/tests to EEST labels May 6, 2025
@winsvega winsvega requested review from marioevz and danceratopz May 6, 2025 09:17
@winsvega winsvega mentioned this pull request May 6, 2025
Open
9 tasks
marioevz
marioevz approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit cce727d into main May 7, 2025
21 checks passed
@marioevz marioevz deleted the coverage branch May 7, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

@danceratopz danceratopz Awaiting requested review from danceratopz

Assignees

@winsvega winsvega

Labels
port Related to porting ethereum/tests to EEST scope:ci Scope: Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winsvega @marioevz