-
Notifications
You must be signed in to change notification settings - Fork 130
chore(fill): ARM solc-select workarounds and sanity version check #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two small comments below!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two last comments.
src/pytest_plugins/solc/solc.py
Outdated
# solc-select current does not support ARM linux | ||
if platform.system().lower() == "linux" and platform.machine().lower() == "aarch64": | ||
error_message = f"Version {version} does not match solc_version {solc_version}\ | ||
and since solc-select currently does not support ARM linux we can not recover from this problem." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your last commit inadvertently deleted the clarification from the previous commit?
and since solc-select currently does not support ARM linux we can not recover from this problem." | |
and since solc-select currently does not support ARM linux you must manually do the following: \ | |
Build solc from source, and manually move the binary to\ | |
.venv/.solc-select/artifacts/solc-x.y.z/solc-x.y.z, then run 'uv run solc-select use <x.y.z>'. |
Also for strings that don't fit in the allowed line-length, please don't use \
, rather do one of the following:
- Use brackets that contain (and concatenate) multiple single-line strings. E.g.,
execution-spec-tests/src/pytest_plugins/filler/filler.py
Lines 93 to 98 in c91549c
help=( "Verify generated fixture JSON files using geth's evm blocktest command. " "By default, the same evm binary as for the t8n tool is used. A different (geth) evm " "binary may be specified via --verify-fixtures-bin, this must be specified if filling " "with a non-geth t8n tool that does not support blocktest." ), textwrap.dedent()
with a multi-line string:
execution-spec-tests/src/pytest_plugins/consume/hive_simulators/conftest.py
Lines 203 to 219 in c91549c
description = textwrap.dedent(f""" <b>Test Details</b> <code>{test_case.id}</code> {f'<a href="{test_url}">[source]</a>' if test_url else ""} {test_docstring} <b>Run This Test Locally:</b> To run this test in <a href="https://github.com/ethereum/hive">hive</a></i>: <code>{hive_clients_yaml_generator_command} {hive_consume_command}</code> <b>Advanced: Run the test against a hive developer backend using EEST's <code>consume</code> command</b> Create the client YAML file, as above, then: 1. Start hive in dev mode: <code>{hive_dev_command}</code> 2. In the EEST repository root: <code>{eest_consume_command}</code> """) # noqa: E501
For this case, I'd go for 1.
β¦y to use solc-select to install solc on arm linux, issue ethereum#1512
9c03fb8
to
b588eff
Compare
Done! |
ποΈ Description
Read the issue for more context
π Related Issues
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.