Skip to content

chore(fill): ARM solc-select workarounds and sanity version check #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

felix314159
Copy link
Collaborator

@felix314159 felix314159 commented May 6, 2025

πŸ—’οΈ Description

Read the issue for more context

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz changed the title ARM solc-select workarounds and sanity version check (Issue #1512) chore(fill): ARM solc-select workarounds and sanity version check May 6, 2025
@danceratopz danceratopz added type:chore Type: Chore scope:fill Scope: fill command labels May 6, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two small comments below!

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two last comments.

# solc-select current does not support ARM linux
if platform.system().lower() == "linux" and platform.machine().lower() == "aarch64":
error_message = f"Version {version} does not match solc_version {solc_version}\
and since solc-select currently does not support ARM linux we can not recover from this problem."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your last commit inadvertently deleted the clarification from the previous commit?

Suggested change
and since solc-select currently does not support ARM linux we can not recover from this problem."
and since solc-select currently does not support ARM linux you must manually do the following: \
Build solc from source, and manually move the binary to\
.venv/.solc-select/artifacts/solc-x.y.z/solc-x.y.z, then run 'uv run solc-select use <x.y.z>'.

Also for strings that don't fit in the allowed line-length, please don't use \, rather do one of the following:

  1. Use brackets that contain (and concatenate) multiple single-line strings. E.g.,
    help=(
    "Verify generated fixture JSON files using geth's evm blocktest command. "
    "By default, the same evm binary as for the t8n tool is used. A different (geth) evm "
    "binary may be specified via --verify-fixtures-bin, this must be specified if filling "
    "with a non-geth t8n tool that does not support blocktest."
    ),
  2. textwrap.dedent() with a multi-line string:
    description = textwrap.dedent(f"""
    <b>Test Details</b>
    <code>{test_case.id}</code>
    {f'<a href="{test_url}">[source]</a>' if test_url else ""}
    {test_docstring}
    <b>Run This Test Locally:</b>
    To run this test in <a href="https://github.com/ethereum/hive">hive</a></i>:
    <code>{hive_clients_yaml_generator_command}
    {hive_consume_command}</code>
    <b>Advanced: Run the test against a hive developer backend using EEST's <code>consume</code> command</b>
    Create the client YAML file, as above, then:
    1. Start hive in dev mode: <code>{hive_dev_command}</code>
    2. In the EEST repository root: <code>{eest_consume_command}</code>
    """) # noqa: E501

For this case, I'd go for 1.

@felix314159 felix314159 force-pushed the solc-versioning-checks branch from 9c03fb8 to b588eff Compare May 7, 2025 09:19
@felix314159
Copy link
Collaborator Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fill Scope: fill command type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants