feat(tests): eip-7883 & eip-7823 modexp cases #1579
Draft
+772
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
added
scope:tests
marioevz
reviewed
May 16, 2025
| Test cases for [EIP-7883: ModExp Gas Cost Increase](https://eips.ethereum.org/EIPS/eip-7883). | ||
| """ | ||
|
|
||
| MODEXP_GAS_INCREASE_FORK_NAME = "Osaka" |
There was a problem hiding this comment.
I think we must also test Prague to validate the gas consumption change.
Comment on lines
44
to
45
| ret_offset=0, | ||
| ret_size=0x80, |
There was a problem hiding this comment.
This could be left as zero and we can use the RETURNDATA* opcodes instead, because sometimes the call fails and we still compare our expected output against the arguments that were used as inputs.
| @pytest.fixture | ||
| def gas_measure_contract(pre: Alloc): | ||
| """Deploys a simple contract to call ModExp and store its success.""" | ||
| # TODO: fix the gas accounting |
There was a problem hiding this comment.
The tricky part is where to insert the Op.GAS since you also want to store the call return, so you could do Op.GAS + call + Op.GAS and then use swaps to move the stack, subtract the gas measurements, and save into storage.
You can use the traces to see exactly where each value is in the stack when the code runs.
spencer-tb
force-pushed
the
spencer-tb/tests/eip-7883
branch
from
64a691b to
f3996c0
Compare
spencer-tb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds tests cases for the 2 modexp EIPs CFI'd in Fusaka: 7883/7823.
Still a WIP.
🔗 Related Issues
N/A
✅ Checklist