feat(benchmark): add jumpi-intense test case #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
|
CC either @jsign @jochem-brouwer @chfast |
chfast
requested changes
Jun 2, 2025
There was a problem hiding this comment.
Agree with the comments from @chfast, also have a small style suggestion, plus a suggestion for a test where the JUMPI performs the jump (instead of "falling through" and thus not performing the jump).
jsign
added
scope:tests
This was referenced Jun 3, 2025
marioevz
reviewed
Jun 3, 2025
4 tasks
jochem-brouwer
requested changes
Jun 4, 2025
|
@jochem-brouwer Thank you so much for the explanation, it really helped me understand the inner workings of the test better. I’ve updated accordingly, and this PR is now ready for review. It would be great if you could take another look. Thanks again! |
jochem-brouwer
requested changes
Jun 17, 2025
|
@jochem-brouwer Thanks for the review, update accordingly! |
jsign
reviewed
Jun 18, 2025
spencer-tb
changed the title
|
#1804 got merged! Please rebase the branch and move the tests to the appropriate folder. |
marioevz
approved these changes
Jul 21, 2025
marioevz
force-pushed
the
feat/add-zkevm-jumpi
branch
from
dbd8af9 to
23be0d8
Compare
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
* feat: add zkevm jumpi-intense op * refactor: update jumpi fallthrough case * feat(tests): add jumpi intensive contract test * chore: fix typo * refactor: optimize jumpi-intensive test case * refactor(tests): replace hardcoded value with fork specific variable * Apply suggestions from code review --------- Co-authored-by: Mario Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add a JUMPI-intensive operation for ZKVm as test case.
Currently
🔗 Related Issues
Update issue #1690
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.