-
Notifications
You must be signed in to change notification settings - Fork 185
(feat)ci: pypy3.11 support #1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97366f3 to
4d2d4f7
Compare
c7d453f to
6b7c7aa
Compare
7240fa0 to
b3b8c0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Really nice to have this!
As a sanity check could you please:
- Compare cpython and pypy 3.11
fillrun times on this branch and cpython on main? - Diff the generated fixtures with pypy on this branch to fixtures generated on main? We use the
hasherutitlity to diff? This should be adequate:
uv run fill -m "not slow and not benchmark" -n auto
I think the docs are a bit borked on this, but this comment explains how to do this:
#792 (review)
I absolutely recommend doing this on the hive server for speed!
caa300d to
494ccaf
Compare
Before Osaka tests became the default, this was working really well. Python 3.12 on main was able to fill tests in 8:49 on the hive-server, and pypy3.11 on this branch was running in 4:48. However, after the Osaka tests became the default, locally and on hive-server I am erroring out. I'm not seeing the same thing on CI, so I am not sure what's going on. It may be worth digging in, but it seems like this isn't a huge priority right now. I took the pypy
The hashes do match! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question but it's not a blocker. Thanks!
Co-authored-by: danceratopz <[email protected]>
494ccaf to
9e9df05
Compare
🗒️ Description
Allows this repo to run using pypy3.11. The new CI job runs in ~15m, which is generally ~30s-1m slower than our next slowest job. I'm happy to spend more time trying to get it down, but didn't know how much priority to give it here.
🔗 Related Issues or PRs
#1839
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.