-
Notifications
You must be signed in to change notification settings - Fork 185
chore(benchmark): don't fill benchmark tests by default #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
I'm considering doing the same for |
|
Couple of questions:
|
b035560 to
18eb694
Compare
|
I added a better solution by modifying the benchmark conftest! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good idea! Just a couple of suggestions that would make it even easier to use IMO.
9998edc to
f6f0508
Compare
|
Filling with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments!
|
I think I addressed your other comments. Nice way to test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
* chore(benchmark): don't fill benchmark tests by default. * chore(benchmark): change to collection level only. * chore: optimizations via review. * chore(tests): pr comments.
ποΈ Description
Updates EEST to not fill benchmark tests by default.
π Related Issues or PRs
#1919
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.