Skip to content

Conversation

@spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Jul 17, 2025

πŸ—’οΈ Description

Updates EEST to not fill benchmark tests by default.

πŸ”— Related Issues or PRs

#1919

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb
Copy link
Collaborator Author

spencer-tb commented Jul 17, 2025

Please check if I have missed anything. It looks like this is all we need!
Seems its running the benchmark tests in tox :P

@spencer-tb
Copy link
Collaborator Author

I'm considering doing the same for -m slow...

@marioevz
Copy link
Member

Couple of questions:

  • How do we run benchmark tests then?
  • Does it still work if we add another -m in the command line?

@spencer-tb spencer-tb force-pushed the benchmark-tests-not-default branch from b035560 to 18eb694 Compare July 18, 2025 10:02
@spencer-tb
Copy link
Collaborator Author

I added a better solution by modifying the benchmark conftest!

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good idea! Just a couple of suggestions that would make it even easier to use IMO.

@spencer-tb spencer-tb force-pushed the benchmark-tests-not-default branch from 9998edc to f6f0508 Compare July 25, 2025 17:40
@spencer-tb
Copy link
Collaborator Author

Filling with the --gas-benchmark-values now only fills benchmark tests. Similar for adding the -m benchmark marker.
Added the optimizations you mentioned too! Thanks :)

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments!

@spencer-tb
Copy link
Collaborator Author

I think I addressed your other comments.

Nice way to test:

uv run fill --fork Prague -m benchmark --clean --co | grep Module
uv run fill --fork Prague --gas-benchmark-values 1 --clean --co | grep Module
uv run fill --fork Prague --clean --co | grep Module

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@marioevz marioevz merged commit 4939c1c into main Jul 25, 2025
16 checks passed
@marioevz marioevz deleted the benchmark-tests-not-default branch July 25, 2025 21:10
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
* chore(benchmark): don't fill benchmark tests by default.

* chore(benchmark): change to collection level only.

* chore: optimizations via review.

* chore(tests): pr comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants