-
Notifications
You must be signed in to change notification settings - Fork 185
fix(static_tests): adjusted gasLimit to only allow gasLimit of up to 30mil #1924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@felix314159 I think they already update the tx gas limit to 2**24 here |
|
I tried to fill the tests (with
I fixed two in the last two commits to get things started:
PTAL at those two examples, and I think the rest of the failing tests also need to be fixed with either of these two methods. |
|
I created an issue to track failing tests from my last comment so we can:
|
6cdc920 to
7e29953
Compare
Done, let's get this merged and then try to fix the rest: as described in #1948 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
β¦30mil (ethereum#1924) * gaslimit applied * new gaslimit is 16,777,216 * fix(tests/static): Skip tstore ddos tests * fix(tests/static): Split CREATE2_FirstByte_loopFiller.yml * reverted changes to problematic tests --------- Co-authored-by: Mario Vega <[email protected]>
ποΈ Description
This replaces the outdate PR #1587
π Related Issues or PRs
N/A.
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.