Skip to content

fix(github): Remove --solc-version flag from fixture building action #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felix314159 merged 2 commits into from
Jul 23, 2025
Merged

fix(github): Remove --solc-version flag from fixture building action #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22267f2
fix(github): Remove `--solc-version` flag from fixture building action
marioevz Jul 23, 2025
95a33a7
fix(github): Remove `solc` from all features
marioevz Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build-fixtures/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ runs:
- name: Generate fixtures using fill
shell: bash
run: |
uv run fill -n ${{ steps.evm-builder.outputs.x-dist }} --evm-bin=${{ steps.evm-builder.outputs.evm-bin }} --solc-version=${{ steps.properties.outputs.solc }} ${{ steps.properties.outputs.fill-params }} --output=fixtures_${{ inputs.release_name }}.tar.gz --build-name ${{ inputs.release_name }}
uv run fill -n ${{ steps.evm-builder.outputs.x-dist }} --evm-bin=${{ steps.evm-builder.outputs.evm-bin }} ${{ steps.properties.outputs.fill-params }} --output=fixtures_${{ inputs.release_name }}.tar.gz --build-name ${{ inputs.release_name }}
- name: Wrap ethereum/tests fixtures with eofwrap tool
shell: bash
if: ${{ steps.properties.outputs.eofwrap }}
Expand Down
5 changes: 0 additions & 5 deletions .github/configs/feature.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,19 @@
stable:
evm-type: stable
fill-params: --until=Prague
solc: 0.8.21
develop:
evm-type: develop
fill-params: --until=Osaka
solc: 0.8.21
static:
evm-type: static
fill-params: --until=Osaka --fill-static-tests ./tests/static
solc: 0.8.21
benchmark_test:
evm-type: benchmark
fill-params: --from=Cancun --until=Prague --gas-benchmark-values 1,10,30,45,60,90,120 -m benchmark --generate-all-formats ./tests
solc: 0.8.21
feature_only: true
eip7692:
evm-type: eip7692
fill-params: --fork=EOFv1 ./tests/unscheduled
solc: 0.8.21
eofwrap: true
feature_only: true
fusaka-devnet-2:
Expand Down
Loading