Skip to content

feat(tests): remove the static performance test calling SHA256 5000x#1949

Merged
marioevz merged 1 commit intoethereum:mainfrom
ipsilon:no_sha256_50000
Jul 25, 2025
Merged

feat(tests): remove the static performance test calling SHA256 5000x#1949
marioevz merged 1 commit intoethereum:mainfrom
ipsilon:no_sha256_50000

Conversation

@chfast
Copy link
Copy Markdown
Member

@chfast chfast commented Jul 24, 2025

🗒️ Description

This test provide no additional coverage for the SHA256 precompile and executes very slowly.

🔗 Related Issues or PRs

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Edit: For any external observers: we are tracking converting these into a new renewed benchmark format in this issue: https://github.com/ethereum/execution-spec-tests/issues/1947

@marioevz marioevz merged commit 59084a7 into ethereum:main Jul 25, 2025
16 checks passed
@marioevz marioevz deleted the no_sha256_50000 branch July 25, 2025 16:30
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants