chore(ci): fix fill prepatched coverage script fork compatibility#2062
chore(ci): fix fill prepatched coverage script fork compatibility#2062spencer-tb merged 1 commit intomainfrom
Conversation
marioevz
left a comment
There was a problem hiding this comment.
LGTM, there's actually a specific return code for pytest when there were no tests collected: https://docs.pytest.org/en/stable/reference/exit-codes.html
But I'm not sure if we return this code from the fill command so this should be ok.
I just checked and we do actually return the same return code as pytest, then we could do: uv run fill $MODIFIED_DELETED_FILES --clean --until=$FILL_UNTIL --evm-bin evmone-t8n --block-gas-limit $BLOCK_GAS_LIMIT -m "state_test or blockchain_test" --output $BASE_TEST_PATH > >(tee -a filloutput.log) 2> >(tee -a filloutput.log >&2)
FILL_RETURN_CODE=$?
if [ $FILL_RETURN_CODE -eq 5 ]; then
echo "any_modified_fixtures=false" >> "$GITHUB_OUTPUT"
exit 0
elif [ $FILL_RETURN_CODE -ne 0 ]; then
echo "Error: failed to generate .py tests from before the PR."
exit $FILL_RETURN_CODE
fi |
0362b78 to
8a9ed05
Compare
Thanks! Updated with this. Removed the Prague bump as it requires us to update the evmone docker image. |
8a9ed05 to
cb2295c
Compare
🗒️ Description
Problem
The coverage workflow's
fill_prepatched_tests.shscript fails when tests cannot run due to fork compatibility issues. This occurs when:--until=CancunThis occurs in #1929 due to the small change in
tests/prague/eip7702_set_code_tx/test_set_code_txs.pyand via the removal of"!tests/prague/**"incoverage.yamlfrom #1970.🔗 Related Issues or PRs
#1929
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.